Comments

You must log in or register to comment.

faerbit t1_j92aovo wrote

Why does it need a PERSONAL access token, when it's just cloning a public repo?! This looks way more shady, than it seems to be (currently!).

1

twistedproton OP t1_j92fkq6 wrote

The repo is public how about you check it first then come back. The access token is only used once and it remains on your local machine.

An access token is used to access the hithub API without rate limits, it enables passwordless authentication .

An unauthenticated user can only get 60 request as compared to almost 5000 using access tokens.

I'll address this in a future version which doesn't need an access token.

−6

plg94 t1_j91e3me wrote

So what you're actually doing is just taking the .gitignore templates from Github, meaning they are not editable and it doesn't work offline.
Not bad per se, but you should definitely add that fact to your readme.

−2

twistedproton OP t1_j91ehvv wrote

It works offline, you only need to initialize the files only once.This downloads the files to a .gitno/templates folder in your home directory. Template generation is entirely offline. Its not yet refined, :) we are still at version 0.1.2

0

twistedproton OP t1_j91emo7 wrote

I'm also thinking of a way to get the templates faster without needed a github access token

2

plg94 t1_j91fev1 wrote

Oh ok. I just took a very quick glance at the code. I still think you should add a very short (one or two sentences) "how it works" to your readme.

1